add new basic message function for gw alert notification #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 89.85% 90.03% +0.17%
==========================================
Files 11 14 +3
Lines 828 953 +125
==========================================
+ Hits 744 858 +114
- Misses 84 95 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…quality filters, add a lighter e2e which not run the observation plan, used to test the slack message flow
…ge for FA, adress the issue 31
…dd more tests with mock, still need to test with the e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adress issue #29, #30, #31, #32, #38
close #29
close #30
close #31
close #32
close #38