add tests for ints with 19 chars #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjfanning
commented
Sep 21, 2024
- based on Large values when decoded to io.circe.Json results in an exception plokhotnyuk/jsoniter-scala#1195
- with int processing, it is common to count the chars and parse as a Long if the chars are <= 19 and BigInteger if above
- this approach can be risky because a few values may be at a little too big to parse as a long and you could get parse issues
cowtowncoder
approved these changes
Sep 21, 2024
| void intsWith19Chars() throws Exception | ||
| { | ||
| final String[] values = new String[] { | ||
| "9223372036854775808", "9999999999999999999" |
There was a problem hiding this comment.
Makes sense, could probably have based first on Long.MAX_VALUE? But will merge as-is.
cowtowncoder
approved these changes
Sep 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.