Skip to content

subliminal plugin logging "Failed... (cannot find any subtitles for now.)" as ERROR #1709

Description

@programatix

Expected behaviour:

"Failed... (cannot find any subtitles for now.)" should be logged as other type of event instead of ERROR.

Actual behaviour:

ERROR logged for failure to find subtitle.

Steps to reproduce:

Use subliminal plugin

Config:

tasks:
  FetchSubsFromPath:
    priority: 20
    filesystem:
      path: 
        - ...
      regexp: '.*\.(avi|mkv|mp4)$'  # only include filenames with these extensions
      recursive: yes
    accept_all: yes
    seen: local                     # seen shouldn't interfer with anything outside this subtitles task
    subliminal:
      exact_match: yes
      providers:
        - addic7ed
        - opensubtitles
        - tvsubtitles
      languages:
        - en
      ...

Log:

2017-02-21 20:02 ERROR    entry         FetchSubsFromPath Failed Continuum.S04E05.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:02 ERROR    entry         FetchSubsFromPath Failed Continuum.S04E01.Lost.Hours.WEB-DL.x264 (cannot find any subtitles for now.)
2017-02-21 20:02 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E05.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:02 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E02.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:02 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E03.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E09.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E06.PROPER.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E07.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E08.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E04.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E12.2.Minute.Warning.720p.WEB-DL.AAC2.0 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E01.720p.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E13.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E11.HDTV.x264 (cannot find any subtitles for now.)
2017-02-21 20:03 ERROR    entry         FetchSubsFromPath Failed Continuum.S03E10.Revolutions.Per.Minute.720p.WEB-DL.AAC2.0 (cannot find any subtitles for now.)

Additional information:

  • Flexget Version: 2.10.6
  • Python Version: 3.6.0
  • Installation method: pip
  • OS and version: AsusWrt

Activity

  1. cvium commented on Mar 25, 2017

    @cvium
    Contributor

    This is not really specific to subliminal plugin. The logging happens when an entry is failed and we have to fail an entry if fetching subtitles fails imo. Semantically, it makes more sense to fail an entry even if it produces more logging.

    I think this is fine as-is. That said, if someone can come up with a better solution, I'd be more than happy to discuss it.

  2. liiight commented on Mar 25, 2017

    @liiight
    Member

    Why not reject instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions