Skip to content

Rejecting episode because detected as season pack  #1986

Description

@andocromn

I have recently encountered an issue where an episode is being rejected because it is detected as a season pack. It does accept it if season_packs is enabled, however the metadata will be incorrect. For sanity purposes, I have also tested with Flexget version 2.10.24, prior to introduction of Season packs support - Phase 1 #1710, and the episode is accepted as expected.

I'm not sure why this is being detected as a season pack, nor do I believe the fault lies in the detection system. It would seem to me that once it is determined as an episode, it should not go through the season pack detection, but I'm not sure that's correct either.

since it does work normally in 2.10.24... It occurs to me that since the introduction of season pack support, anything detected as a season pack is either accepted or rejected. There is not an option to disable the season pack parser from running or to configure Flexget to not make decisions about season packs. Personally, I see no reason to explicitly reject the season packs verses leaving them undecided.

Expected behavior:

Should be accepted as episode

Actual behavior:

Entry initially determines episode number properly, however it is later detected as a season pack and subsequently is rejected

Steps to reproduce:

Use provided config and example input

Config:

tasks:
  test1:
    rss: /home/test/input.rss
    all_series:
      target: 720p

Log:

2017-10-12 15:42 TRACE    entry         test1           ENTRY SET: description = u'Show Name:Mr. Robot; Show Title: eps3.0_power-saver-mode.h (720p .mkv HDTV); Season: 3; **Episode: 01**; Filename: Mr.Robot.S03E01.720p.HDTV.x264-AVS.mkv'
2017-10-12 15:42 DEBUG    parser_internal test1           Parsing result: <SeriesParser(data=Mr. Robot - 3x01 - eps3.0_power-saver-mode.h (720p .mkv HDTV),name=Mr Robot,id=S3,season=3,**season_pack=True,episode=None**,quality=720p hdtv,proper=0,status=OK)> (in 21.011 ms)
2017-10-12 15:42 VERBOSE  task          test1           REJECTED: `Mr. Robot - 3x01 - eps3.0_power-saver-mode.h (720p .mkv HDTV)` by series plugin because season pack support is turned off

Additional information:

  • FlexGet version: 2.10.98
  • Python version: 2.7.13
  • Installation method: pip
  • Using daemon (yes/no): no
  • OS and version: Debian Stretch
  • Link to crash log: no crash

Activity

  1. liiight commented on Oct 12, 2017

    @liiight
    Member

    I think it trips the regexp because of the s3. part in the episode title. Probably just need to tweak the regexp a bit

  2. andocromn commented on Oct 12, 2017

    @andocromn
    ContributorAuthor

    that makes sense, the episode names of this show are quite unusual. I'm not very strong with regexp

    any thoughts on my comment regarding the changes introduced by the default handling of the season_packs plugin?

  3. added a commit that references this issue on Oct 14, 2017
    b358d01
  4. lmariscal commented on May 28, 2020

    @lmariscal

    I'm having a similar problem where the title of the series is [HorribleSubs] Kaguya-sama wa Kokurasetai S2 - 06 [1080p].mkv so it detects it as a season_pack. Have found no way of disabling the season_pack parser from stopping the other eps from being downloaded.

  5. andocromn commented on May 28, 2020

    @andocromn
    ContributorAuthor

    @lmariscal FYI this issue has already been resolved, your issue appears to be different. My best guess the episode numbering can't be found because there is no "e" before the 06

  6. BrutuZ commented on May 28, 2020

    @BrutuZ
    Contributor

    @andocromn Not an issue when identified by sequence.


    @lmariscal I have this show working just fine for me with the following config under series:

        - "Kaguya-sama wa Kokurasetai?: Tensai-tachi no Renai Zunousen":
            alternate_name: ['Kaguya-sama wa Kokurasetai? Tensai-tachi no Renai Zunousen 2', 'Kaguya-sama wa Kokurasetai S2']
            from_group: ['Erai-raws', 'HorribleSubs']

    Logged entries:

    ┌Kaguya-sama wa Kokurasetai?: Tensai-tachi no Renai Zunousen──────────────────────────────────────────────────────────┬─────────────────┬────────┐
    │ Identifier │ Last seen │ Release titles                                                                             │ Release Quality │ Proper │
    ├────────────┼───────────┼────────────────────────────────────────────────────────────────────────────────────────────┼─────────────────┼────────┤
    │ 6          │ 11d 18h   │ [Erai-raws] Kaguya-sama wa Kokurasetai! Tensai-tachi no Renai Zunousen 2 - 06 [1080p].mkv  │ 1080p           │        │
    │            │           │ [Erai-raws] Kaguya-sama wa Kokurasetai! Tensai-tachi no Renai Zunousen 2 - 06 [720p].mkv * │ 720p            │        │
    │            │           │ [HorribleSubs] Kaguya-sama wa Kokurasetai S2 - 06 [720p].mkv                               │ 720p            │        │
    │ 7          │ 4d 20h    │ [Erai-raws] Kaguya-sama wa Kokurasetai! Tensai-tachi no Renai Zunousen 2 - 07 [1080p].mkv  │ 1080p           │        │
    │            │           │ [Erai-raws] Kaguya-sama wa Kokurasetai! Tensai-tachi no Renai Zunousen 2 - 07 [720p].mkv * │ 720p            │        │
    │            │           │ [HorribleSubs] Kaguya-sama wa Kokurasetai S2 - 07 [1080p].mkv                              │ 1080p           │        │
    │            │           │ [HorribleSubs] Kaguya-sama wa Kokurasetai S2 - 07 [720p].mkv                               │ 720p            │        │
    │            │           │ [HorribleSubs] Kaguya-sama wa Kokurasetai S2 - 07 [360p].mkv                               │ 360p            │        │
    └────────────┴───────────┴────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────┴────────┘
    

    FWIW, it'd probably be better to have opened a new issue filling the template with the details to your case and maybe just referencing this issue number instead of comment on it since it's closed as resolved over 2 years ago. I've only seen it because unlike the issues page, the bot doesn't filter out closed issues when posting on the news channel of the chat.

  7. lmariscal commented on May 28, 2020

    @lmariscal

    @BrutuZ thank you!
    And yeah, sorry, I should have opened a new issue but just wanted to comment out that I had the same issue, not really looking for an answer since I was still looking for a way to fix it with the regex or as you suggested alternate_name. Nonetheless thank you so much for the fix!

  8. arthurwolf commented on Apr 30, 2022

    @arthurwolf

    I still have this problem (with the "S2 - 07" format), where do I find a regex to edit to fix this?
    (on the same series, Kaguya-Sama, just season 3 now)

  9. BrutuZ commented on Apr 30, 2022

    @BrutuZ
    Contributor
  10. arthurwolf commented on Apr 30, 2022

    @arthurwolf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions