Escort service unavailable bug #2804
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a detailed summary of what I did to attempt to fix the bug. Not sure if this is what you're looking for but this resolved the problem where Escort Service goes on cooldown when there are still moves left.
The Escort Service ability was incorrectly showing as unavailable even when the Scavenger had sufficient movement points. This was caused by passing incorrect parameters to getFlyingRange(). Root cause: - getFlyingRange() was called with a modified x position and combined size (Scavenger size + target size) - This caused it to return hexes on different rows (y-coordinates) than where the creatures actually were - All returned hexes were filtered out because they didn't match crea.y - Result: usableHexes.length = 0 even with movement available Fix: - Use Scavenger's actual position (crea.x, crea.y) instead of modified position - Use Scavenger's size (crea.size) instead of combined size - This returns hexes on the correct row where the ability can be used Fixes intermittent unavailability after moving around the map.
…ecker757/AncientBeast into escort-service-unavailable-bug
|
@decker757 is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@decker757 "Testing" = all dead links. Rather upload previews here. That link to the MD file is also broken. I've tested a bit, works better than current master, but still bumped into a bug: Same goes with turn start in front of Headless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Escort Service Availability Bug
I am not sure if this is the fix you're looking for, but it resolves the premature cooldown issue I was experiencing.
This fixes #2802
Problem
Escort Service ability becomes unavailable even when Scavenger has movement points remaining. This happens intermittently after moving around the map.
Root Cause
getEscortUsableHexes()was callinggetFlyingRange()with incorrect parameters:getFlyingRangeto return hexes on wrong rowsusableHexes.length = 0Solution
crea.x, crea.ycrea.sizeTesting
See ESCORT_SERVICE_FIX.md for detailed before/after comparison and testing instructions.
https://streamable.com/svz8rc [before patch - cooldown was premature]
https://streamable.com/avm0yu [after patch - cooldown is correct]
Video links expire in 2 days (30th October where I am from)