Add tooling to check if config changes are honored #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07b6ef1 to
4a7e113
Compare
Will help adding checks on the final .config file
1. Align with the overall approach 2. Will help in adding checks that final config file did end up with that change
To only install deps then quit
Don't assume the script is always being run while on the same directory, use the script's directory as a reference. We still assume install.sh is in the `linux-tkg` root folder
For every kernel version
seems to not be usable directly : CONFG_TCP_CONG_RENO doesn't exist
already undefined with !MAXSMP
They don't exist
disabling PSI makes that config unused and undefined
The config doesn't exist
doesn't exist starting 6.0, probably long solved issue since. Stick with defaults instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparescript check if all the config changes it did got actually applied aftermake olddefconfig, it also creates an additional 3 log files/logs/tkg-all-config-changes.txt: contains all the config changes it did/logs/tkg-failed-config-diffs.md.txt: contains a markdown table of the config changes that did not get honored, in "wanted" vs "actual"/logs/tkg-failed-configs.txt: contains the name of the non-honored configs onlylinux-tkg-config/config-checkerthat goes through every kernel version and runsyes "" | ./install.sh configand aggregates the non-honored configs into its (markdown) output