Skip to content

fix compilation error #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilin212 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix compilation error #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe8141e
fix: fix compilation error on linux
lilin212 Jan 7, 2024
d806aa2
fix: fix compilation error on windows
lilin212 Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/kiwi/base/files/file.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ typedef struct stat stat_wrapper_t;
}
#elif BUILDFLAG(IS_POSIX)
struct stat64;
namespace base {
namespace kiwi::base {
typedef struct stat64 stat_wrapper_t;
}
#endif
Expand Down
4 changes: 4 additions & 0 deletions src/kiwi/base/files/file_enumerator_win.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
#include "base/win/shlwapi.h"
#include "base/win/windows_types.h"

#ifdef _MSC_VER
#pragma comment(lib, "Shlwapi.lib")
#endif

#if defined(max)
#undef max
#endif
Expand Down
2 changes: 2 additions & 0 deletions src/kiwi/third_party/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.

set (CMAKE_POSITION_INDEPENDENT_CODE ON)

add_subdirectory(glog)
add_subdirectory(SDL2)
add_subdirectory(nes_apu)
Expand Down