Skip to content

[FIX] level check #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Geuthur merged 1 commit into from
Oct 28, 2025
Merged

[FIX] level check #51

Geuthur merged 1 commit into from
Oct 28, 2025

Conversation

@Geuthur
Copy link
Owner

@Geuthur Geuthur commented Oct 28, 2025

Description

Please include a summary of the changes and the related issue number (if applicable).

Fixed

  • level check

Type of Changes

Please select the type of changes made in this pull request:

  • Bug Fix (non-breaking change which fixes an Issue)
  • New Feature (non-breaking change)
  • Other (please specify):

Checklist

Please ensure the following before submitting your pull request:

  • I have read the contributing guidelines.
  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • All new and existing tests passed.

@Geuthur Geuthur merged commit 5828d42 into master Oct 28, 2025
28 checks passed
@Geuthur Geuthur deleted the fix-validator branch October 28, 2025 11:17
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
madc/models/skillchecker.py 0.00% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   48.42%   48.47%   +0.05%     
==========================================
  Files          28       28              
  Lines        1012     1011       -1     
  Branches      140      140              
==========================================
  Hits          490      490              
+ Misses        484      483       -1     
  Partials       38       38
Files with missing lines Coverage Δ
madc/models/skillchecker.py 64.11% <0.00%> (+1.61%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cfaf3...ffea810. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Geuthur