Skip to content

Conversation

@rajababubula
Copy link

Updated code to check the record type and parse if text or URL

Updated code to check the record type and parse if text or URL
@google-cla
Copy link

google-cla bot commented Jun 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please have a look at my comments.

}
}
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we have a spacer to make it clear there are multiple records?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. I want to further parse other types of tags as well. is this fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'd parse more types in a sample like this.

Copy link
Member

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error Uncaught SyntaxError: missing ) after argument list.
Please try your PR locally.

@beaufortfrancois beaufortfrancois force-pushed the gh-pages branch 7 times, most recently from c198a70 to 03c4155 Compare November 26, 2022 06:50
@beaufortfrancois beaufortfrancois force-pushed the gh-pages branch 5 times, most recently from 1de1b35 to c4f3954 Compare October 16, 2023 10:28
@805983439
Copy link

Updated code to check the record type and parse if text or URL

Necesito código universal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants