Enable opencensus for core Google FluentD metrics #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the old Prometheus/collectd-based approach with a push implementation based on OpenCensus.
igorpeshansky
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will use OpenCensus for exporting the metrics under the
agent.googleapis.com/agentprefix to Stackdriver. This makes monitoring work out-of-the-box, as opposed to the previous mechanism, which relied on either a Prometheus collector or the Stackdriver Monitoring agent.I successfully tested this on a fresh installation early last week. All the backend changes are in place.
@igorpeshansky @qingling128 can you please review and confirm that these files are used by the GCE packages?