Skip to content

chore(dep upgrade): Dependency upgrades #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2025
Merged

chore(dep upgrade): Dependency upgrades #3740

merged 1 commit into from
Sep 2, 2025

Conversation

@kislaykishore
Copy link
Collaborator

@kislaykishore kislaykishore commented Aug 25, 2025 •
edited
Loading

Description

Upgrade direct dependencies.

Command: go get $(go list -f '{{if not (or .Main .Indirect)}}{{.Path}}{{end}}' -m all)

Perf:

Branch File Size Read BW Write BW RandRead BW RandWrite BW
Master 0.25MiB 552.3MiB/s 1.29MiB/s 78.3MiB/s 1.25MiB/s
PR 0.25MiB 574.75MiB/s 1.23MiB/s 78.88MiB/s 1.25MiB/s
Master 48.828MiB 3987.8MiB/s 81.72MiB/s 1532.67MiB/s 83.47MiB/s
PR 48.828MiB 3846.19MiB/s 86.27MiB/s 1561.08MiB/s 86.28MiB/s
Master 976.562MiB 3845.48MiB/s 37.78MiB/s 850.9MiB/s 39.19MiB/s
PR 976.562MiB 3847.61MiB/s 37.64MiB/s 1247.06MiB/s 39.24MiB/s

Link to the issue in case of a bug fix.

b/441052854

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

No

@kislaykishore kislaykishore added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Aug 25, 2025
@codecov
Copy link

codecov bot commented Aug 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.41%. Comparing base (7812347) to head (c626cf3).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3740       +/-   ##
===========================================
+ Coverage        0   82.41%   +82.41%     
===========================================
  Files           0      144      +144     
  Lines           0    23096    +23096     
===========================================
+ Hits            0    19034    +19034     
- Misses          0     3518     +3518     
- Partials        0      544      +544
Flag Coverage Δ
unittests 82.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kislaykishore kislaykishore marked this pull request as ready for review August 27, 2025 08:08
@kislaykishore kislaykishore requested a review from a team as a code owner August 27, 2025 08:08
@github-actions
Copy link

github-actions bot commented Aug 27, 2025

/gemini review

@github-actions
Copy link

github-actions bot commented Aug 27, 2025

/gemini summary

@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Aug 27, 2025
@kislaykishore kislaykishore enabled auto-merge (squash) August 27, 2025 08:10
@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Hi @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

3 similar comments
@github-actions
Copy link

github-actions bot commented Aug 29, 2025

Hi @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Hi @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Hi @raj-prince, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

abhishek10004
abhishek10004 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@abhishek10004 abhishek10004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raj-prince
raj-prince approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@raj-prince raj-prince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, the ideal way to update the grpc or any Go-SDK dependencies while upgrading Go-SDK, but this leads to manual toil.

Given we perform a lot of testing in GCSFuse we can keep the update process generic for all the library.

@kislaykishore kislaykishore merged commit 3712cba into master Sep 2, 2025
18 checks passed
@kislaykishore kislaykishore deleted the dep-upgrade branch September 2, 2025 09:38
@BrewTestBot BrewTestBot mentioned this pull request Sep 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhishek10004 abhishek10004 abhishek10004 approved these changes

@raj-prince raj-prince raj-prince approved these changes

Assignees

No one assigned

Labels

execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kislaykishore @abhishek10004 @raj-prince