Skip to content

fix(unmount): Fixing false unmount success bug #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

fix(unmount): Fixing false unmount success bug #3768

merged 2 commits into from
Sep 1, 2025

Conversation

@raj-prince
Copy link
Collaborator

@raj-prince raj-prince commented Sep 1, 2025 •
edited by kislaykishore
Loading

Description

Bringing jacobsa/fuse changes to fix false unmount success issue. Ref: jacobsa/fuse#182

Branch File Size Read BW Write BW RandRead BW RandWrite BW
Master 0.25MiB 560.49MiB/s 1.21MiB/s 76.93MiB/s 1.26MiB/s
PR 0.25MiB 549.93MiB/s 1.21MiB/s 75.9MiB/s 1.09MiB/s
Master 48.828MiB 2576.42MiB/s 80.87MiB/s 1441.35MiB/s 80.36MiB/s
PR 48.828MiB 2893.17MiB/s 80.91MiB/s 1348.24MiB/s 81.6MiB/s
Master 976.562MiB 2432.59MiB/s 38.27MiB/s 612.33MiB/s 38.05MiB/s
PR 976.562MiB 2454.67MiB/s 37.5MiB/s 718.79MiB/s 38.35MiB/s

Link to the issue in case of a bug fix.

b/441428405

Testing details

  1. Manual - Yes, working fine.
  2. Unit tests - NA
  3. Integration tests - NA

Any backward incompatible change? If so, please explain.

@raj-prince raj-prince requested a review from a team as a code owner September 1, 2025 04:19
@github-actions github-actions bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Sep 1, 2025
@raj-prince raj-prince added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests and removed remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. labels Sep 1, 2025
@raj-prince raj-prince enabled auto-merge (squash) September 1, 2025 04:20
@codecov
Copy link

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.48%. Comparing base (d9b1208) to head (fb063df).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3768       +/-   ##
===========================================
+ Coverage        0   82.48%   +82.48%     
===========================================
  Files           0      144      +144     
  Lines           0    23075    +23075     
===========================================
+ Hits            0    19033    +19033     
- Misses          0     3500     +3500     
- Partials        0      542      +542
Flag Coverage Δ
unittests 82.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raj-prince raj-prince merged commit e154e6d into master Sep 1, 2025
16 checks passed
@kislaykishore kislaykishore deleted the unmount_sigint_bug branch September 1, 2025 08:03
@BrewTestBot BrewTestBot mentioned this pull request Sep 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kislaykishore kislaykishore kislaykishore approved these changes

Assignees

No one assigned

Labels

execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raj-prince @kislaykishore