[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kallisti5
Once this PR has been reviewed and has the lgtm label, please assign illfelder for approval by writing /assign @illfelder in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @kallisti5. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

makefile: Don't assume json-c header path is more generic and probably more likely to be accepted. Assuming include paths is bad form, and pkg-config should be used when available.

haiku: Add Haiku support enables compiling google_authorization_keys for Haiku. Haiku runs on GCE, and this would be a step closer to functional os-login.

Haiku, Inc. is investigating a community GCE image via the "haiku-inc" project and can pre-package this with the OS.

/ok-to-test

Makefile change looks fine, but we can't start adding arbitrary OS support here. I think you should simply fork this to your package management system and patch in any changes needed - that's what Debian, Ubuntu and SLES do today.

@kallisti5: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

@hopkiw It's ok, I ended up writing our own to use the ssh metadata. We really don't have what it takes for oslogin (aka pam)

https://github.com/kallisti5/smolcloudtools/blob/master/gce_metadata_ssh.cpp