Skip to content

Modify saphana configuration file to use wildcard log paths #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

Modify saphana configuration file to use wildcard log paths #1061

merged 1 commit into from
Jan 26, 2023

Conversation

@sophieyfang
Copy link
Contributor

@sophieyfang sophieyfang commented Jan 25, 2023 •
edited
Loading

Description

Related issue

b/265978333

How has this been tested?

third party e2e test in the presubmit shall do

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@sophieyfang sophieyfang requested review from a team and qingling128 and removed request for a team January 26, 2023 15:49
qingling128
qingling128 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophieyfang sophieyfang merged commit 3edd0d6 into master Jan 26, 2023
@sophieyfang sophieyfang deleted the sophieyfang-patch-10 branch January 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingling128 qingling128 qingling128 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sophieyfang @qingling128