Testing: use UUID for script name in case of concurrency #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscovalentecastro
approved these changes
Jan 27, 2023
| if err := UploadContent(ctx, logger, vm, strings.NewReader(scriptContents), "C:\\temp.ps1"); err != nil { | ||
| // Use a UUID for the script name in case RunScriptRemotely is being | ||
| // called concurrently on the same VM. | ||
| scriptPath := "C:\\"+uuid.NewString()+".ps1" |
There was a problem hiding this comment.
Just one comment about using uuid.NewString() for the path. Are all possible characters from a uuid string valid for a Windows filename ?
There was a problem hiding this comment.
it's just lowercase 0-9a-f plus hyphens, shold be OK. Plus it (mostly) pasesd tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RunScriptRemotely()has had a bug for a long time that nobody has ever triggered if it is called multiple times concurrently on the same VM. This PR fixes the bug before anybody runs into it.Related issue
none
How has this been tested?
automated tests should be enough.
Checklist: