Skip to content

Fixes for feature tracking release #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 9, 2022
Merged

Fixes for feature tracking release #1020

merged 8 commits into from
Dec 9, 2022

Conversation

@avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Dec 8, 2022 •
edited by qingling128
Loading

Description

Fixes for feature tracking release

  • Disable tracking for modify_fields because map is not supported
  • Add a 10 second delay to the initial feature tracking and enabled_receiver metrics flush to avoid metrics conflict due to the interval being too short. This was a problem during integration tests. See details in b/261723537

Related issue

b/261723537

How has this been tested?

Integration tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
braydonk
braydonk reviewed Dec 8, 2022
View reviewed changes
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@avilevy18 avilevy18 marked this pull request as ready for review December 8, 2022 19:28
@avilevy18 avilevy18 requested review from a team and qingling128 and removed request for a team December 8, 2022 19:28
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
qingling128
qingling128 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There is some offline discussion with the Open Telemetry SDK folks to see whether this workaround is reasonable. Will confirm.

@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 8, 2022
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 9, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 9, 2022
@avilevy18 avilevy18 requested a review from qingling128 December 9, 2022 17:09
qingling128
qingling128 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingling128
Copy link
Contributor

qingling128 commented Dec 9, 2022

The remaining failing tests are for query log only and is unrelated to this change. Merging.

@qingling128 qingling128 merged commit deaa7de into master Dec 9, 2022
@qingling128 qingling128 deleted the avilevy-feature-tracking-fixes branch December 9, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braydonk braydonk braydonk left review comments

@qingling128 qingling128 qingling128 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avilevy18 @qingling128 @braydonk @stackdriver-instrumentation-release