Skip to content

Add feature tracking integration tests for third party apps #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 9, 2023
Merged

Add feature tracking integration tests for third party apps #1021

merged 7 commits into from
Jan 9, 2023

Conversation

@avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Dec 12, 2022 •
edited
Loading

Description

Adding golden error tests for feature extraction & feature tracking integration tests.

Due to b/245754378 saphana integration tests are not included.

Related issue

b/246812070

How has this been tested?

Integration tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@avilevy18 avilevy18 changed the title Added feature tracking integration tests for third party apps Add feature tracking integration tests for third party apps Dec 12, 2022
@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 12, 2022
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 12, 2022
@avilevy18 avilevy18 marked this pull request as ready for review December 13, 2022 16:41
@avilevy18 avilevy18 requested review from a team and ridwanmsharif and removed request for a team December 13, 2022 16:41
@avilevy18 avilevy18 merged commit 2ac1cd8 into master Jan 9, 2023
@qingling128 qingling128 mentioned this pull request Feb 7, 2023
Closed
9 tasks
@igorpeshansky igorpeshansky deleted the avilevy-feature-tracking-golden-errors branch July 10, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avilevy18 @ridwanmsharif @stackdriver-instrumentation-release