Skip to content

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Mar 16, 2023

Description

This change splits up test_config.yaml, putting its contents into each app's metadata.yaml file. This is nice from a tidiness perspective, because there are fewer files to worry about, but it's also nice because now when you adjust the test skips for an app, it doesn't run all tests for all apps, which is what it had to do when there was a central test_config.yaml file. This is extra nice because running all tests for all apps is "heavy" in that it takes longer and is more likely to overload the apache servers, run us out of various quotas, etc.

Related issue

offshoot of b/270147175.

How has this been tested?

In addition to automated tests, I ran the tests before and after this change and verified that the PASS/SKIP log messages were identical before and after (after sorting). They were, after fixing some bugs.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans requested review from sophieyfang and removed request for ridwanmsharif March 16, 2023 18:37
@martijnvans
Copy link
Contributor Author

some things are still running, but I had a clean run previously so I'm going to call this good.

@martijnvans martijnvans merged commit 7127655 into master Mar 22, 2023
@martijnvans martijnvans deleted the martijnvans-split-test-config branch March 22, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants