Skip to content

Testing: Make release builds use go_test.sh #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2023
Merged

Testing: Make release builds use go_test.sh #1172

merged 3 commits into from
Mar 24, 2023

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Mar 23, 2023

Description

This is to fix last night's failures, which were due to the release builds using the new script go_test_for_containers.sh with the old non-docker-based pool.

Related issue

nightlies failed

How has this been tested?

Not sure how to test this besides merging it and trying it out.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans
Testing: Make release builds use go_test.sh
2b43ced 
This is to fix last night's failures, which were due to the release builds using the new script `go_test_for_containers.sh` with the old non-docker-based pool.
@martijnvans
also use old script for 3p tests
471f2ec
@martijnvans martijnvans marked this pull request as ready for review March 23, 2023 16:37
@martijnvans martijnvans requested a review from Subbarker March 23, 2023 16:37
@jefferbrecht jefferbrecht merged commit 5f7c535 into master Mar 24, 2023
@martijnvans martijnvans deleted the martijnvans-release-builds-old-script branch April 10, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Subbarker Subbarker Subbarker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martijnvans @Subbarker @jefferbrecht