Skip to content

patch for handle leak #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2023
Merged

patch for handle leak #1190

merged 3 commits into from
Apr 12, 2023

Conversation

@braydonk
Copy link
Contributor

@braydonk braydonk commented Apr 11, 2023 •
edited by igorpeshansky
Loading

Description

This is for a custom build to address the Windows file handle leaking issue.

Related issue

b/276461606
omg/61928

How has this been tested?

Manually and the integration tests of this PR.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@braydonk braydonk added the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 11, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Apr 11, 2023
@braydonk braydonk merged commit 5ef95f6 into master Apr 12, 2023
@igorpeshansky igorpeshansky deleted the braydonk-handle-leak-fix branch July 10, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@braydonk @ridwanmsharif @stackdriver-instrumentation-release