Skip to content

[ubuntu-lunar] Lunar 3p integration testing support #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 25, 2023
Merged

[ubuntu-lunar] Lunar 3p integration testing support #1254

merged 21 commits into from
May 25, 2023

Conversation

@mrsillydog
Copy link
Collaborator

@mrsillydog mrsillydog commented May 15, 2023

Description

Third party integration testing updates for Ubuntu 23.04 (Lunar Lobster).

How has this been tested?

#1234

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

igorpeshansky
igorpeshansky reviewed May 15, 2023
View reviewed changes
@igorpeshansky igorpeshansky changed the title [ubuntu-lunar] Lunar 3p intg testing support [ubuntu-lunar] Lunar 3p integration testing support May 18, 2023
@martijnvans martijnvans added the kokoro:force-run Forces kokoro to run integration tests on a CL label May 22, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label May 22, 2023
@mrsillydog mrsillydog requested a review from igorpeshansky May 22, 2023 17:31
igorpeshansky
igorpeshansky reviewed May 23, 2023
View reviewed changes
@dehaansa dehaansa requested a review from igorpeshansky May 23, 2023 20:09
igorpeshansky
igorpeshansky reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments, one optional.

igorpeshansky
igorpeshansky reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, one more minor one.

@dehaansa dehaansa requested a review from igorpeshansky May 25, 2023 13:02
igorpeshansky
igorpeshansky approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@martijnvans martijnvans merged commit b3620c5 into GoogleCloudPlatform:master May 25, 2023
@dehaansa dehaansa mentioned this pull request Jun 12, 2023
Closed
9 tasks
@mrsillydog mrsillydog deleted the ubuntu-lunar branch June 27, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvans martijnvans martijnvans approved these changes

+2 more reviewers

@dehaansa dehaansa dehaansa left review comments

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrsillydog @dehaansa @igorpeshansky @martijnvans @stackdriver-instrumentation-release