Skip to content

Testing: tweaks to soak test #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 22, 2023
Merged

Testing: tweaks to soak test #1264

merged 5 commits into from
May 22, 2023

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented May 22, 2023 •
edited
Loading

Description

This PR:

  • Moves launcher into a cmd directory
  • Adds a presubmit.gcl config so that we can have kokoro test the launcher on each PR
  • Increases the default TTL to 30 minutes to accommodate Windows being slower to start up
  • moves README content to the soak_test directory.

Related issue

b/278590309

How has this been tested?

none, automated tests are coming in a follow up change inside google3

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans requested a review from quentinmit May 22, 2023 17:16
quentinmit
quentinmit reviewed May 22, 2023
View reviewed changes
Copy link
Member

@quentinmit quentinmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main file should be named .../cmd/launcher/main.go. The convention is that .../cmd/$foo/ is a directory containing the file(s) needed to build the binary named $foo.

@martijnvans
Copy link
Contributor Author

martijnvans commented May 22, 2023

The main file should be named .../cmd/launcher/main.go.

OK, done

quentinmit
quentinmit reviewed May 22, 2023
View reviewed changes
Copy link
Member

@quentinmit quentinmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to change the opentelemetry-operations-collector submodule in this commit.

@martijnvans martijnvans deleted the martijnvans-move-files branch May 22, 2023 19:47
@martijnvans martijnvans restored the martijnvans-move-files branch May 22, 2023 19:48
@martijnvans martijnvans deleted the martijnvans-move-files branch May 22, 2023 19:52
@martijnvans martijnvans reopened this May 22, 2023
@martijnvans martijnvans merged commit 1669c5c into master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quentinmit quentinmit quentinmit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvans @quentinmit