Skip to content

Testing: Remove ZONE environment variable, long live ZONES #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2023
Merged

Testing: Remove ZONE environment variable, long live ZONES #1274

merged 3 commits into from
May 30, 2023

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented May 25, 2023 •
edited
Loading

Description

PR #1224 added support for ZONES, and a changelist in google3 with description "Use new ZONES variable to spread load across zones/regions." switched the last caller to use it instead of ZONE. There is still a test using its own environment variable called ZONE, but not relying on gce_testing.go to use it.

Related issue

b/280064697

How has this been tested?

automated tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans requested a review from igorpeshansky May 25, 2023 20:04
igorpeshansky
igorpeshansky approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@martijnvans martijnvans merged commit 8a372a6 into master May 30, 2023
@martijnvans martijnvans deleted the martijnvans-remove-zone branch May 30, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvans @igorpeshansky