Skip to content

Testing: get release soak tests to use protected service account #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

Testing: get release soak tests to use protected service account #1278

merged 1 commit into from
May 30, 2023

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented May 30, 2023

Description

This should fix issues like http://sponge2/346f6348-9c7c-440e-b03d-cb6cf937e3df.

Related issue

b/278590309

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans
Testing: get release soak tests to use protected service account
1799bc6 
This should fix issues like http://sponge2/346f6348-9c7c-440e-b03d-cb6cf937e3df.
@martijnvans martijnvans requested a review from Subbarker May 30, 2023 18:22
@martijnvans martijnvans merged commit b4fb1be into master May 30, 2023
@martijnvans martijnvans deleted the martijnvans-use-internal-service-account branch May 30, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Subbarker Subbarker Subbarker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvans @Subbarker