Skip to content

Add dockerfile updates to support Debian 12 Bookworm #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2023
Merged

Add dockerfile updates to support Debian 12 Bookworm #1295

merged 3 commits into from
Jun 21, 2023

Conversation

@ridwanmsharif
Copy link
Contributor

@ridwanmsharif ridwanmsharif commented Jun 20, 2023 •
edited by braydonk
Loading

Description

This PR adds dockerfile changes to support the Ops Agent on bookworm. It temporarily hijacks the bullseye target to test bookworm. Will revert this last commit once tests are green.

Related issue

b/217366205 | P1 | Support Debian 12 for Ops Agent
#1294

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif-bookworm branch 2 times, most recently from 0ae7377 to d45bc19 Compare June 20, 2023 22:02
@ridwanmsharif
Add dockerfile changes for building on bookworm
84c75ca 
Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif-bookworm branch from d45bc19 to f2b02a8 Compare June 20, 2023 22:02
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif-bookworm branch from f2b02a8 to 10fc407 Compare June 20, 2023 22:05
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 21, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jun 21, 2023
@ridwanmsharif ridwanmsharif requested review from a team and braydonk and removed request for a team June 21, 2023 01:32
braydonk
braydonk approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm assuming the third party apps test failing is expected since we haven't actually done the script fixes for those yet?

@ridwanmsharif ridwanmsharif merged commit dc73fda into master Jun 21, 2023
@igorpeshansky igorpeshansky deleted the ridwanmsharif-bookworm branch July 10, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelwestphal rafaelwestphal rafaelwestphal approved these changes

@braydonk braydonk braydonk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ridwanmsharif @rafaelwestphal @braydonk @stackdriver-instrumentation-release