Skip to content

Conversation

@martijnvans
Copy link
Contributor

Description

This PR removes fetch_keystore because its functionality is so trivial that it can just be inlined.

Related issue

none, cleanup

How has this been tested?

We'll have to see if release builds break with this change included. Automated tests don't touch this codepath.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans requested a review from Subbarker April 20, 2023 17:00
@martijnvans martijnvans merged commit 8655f1f into master Apr 20, 2023
@martijnvans martijnvans deleted the martijnvans-simplify-keystore-2 branch April 20, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants