Skip to content

Disallow zero for log rotation's backup_count parameter #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

Disallow zero for log rotation's backup_count parameter #1204

merged 1 commit into from
Apr 18, 2023

Conversation

@hsmatulis
Copy link
Contributor

@hsmatulis hsmatulis commented Apr 17, 2023 •
edited
Loading

Description

This is a follow up to #1102. If 0 is passed in to lumberjack for the BackupCount, lumberjack will not limit the number of backup log files. This is counter-intuitive so for now lets disallow 0

Related issue

b/203811937

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@hsmatulis hsmatulis requested a review from jefferbrecht April 17, 2023 22:57
@hsmatulis hsmatulis merged commit a701098 into master Apr 18, 2023
@hsmatulis hsmatulis deleted the log-rotate-no-zero branch April 18, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefferbrecht jefferbrecht jefferbrecht approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsmatulis @jefferbrecht