Removing logging of metadata query result #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/healthchecks/api_check.go
Outdated
| ctx := context.Background() | ||
| gceMetadata, err := getGCEMetadata() | ||
| if err != nil { | ||
| return fmt.Errorf("can't get GCE metadata: %w", err) |
There was a problem hiding this comment.
After thinking this after a couple of days. I think removing the err here is a good idea. We already have a Network Check that queries the metadata server and the error here might (in a super rare case) could expose PII details (e.g. can't find attribute x). The API Check responsibility is not to verify the metadata server.
Just leaving (or improving a little) the message should be enough.
fmt.Errorf("can't get GCE metadata`)
Synced with @LujieDuan about this before. CC if he has more opinions about this.
LujieDuan
approved these changes
May 1, 2023
rafaelwestphal
added a commit
that referenced
this pull request
May 2, 2023
* Removing exposure of metadata query result * Also removing print on error path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the result from metadata query from being added to health-checks.log
Related issue
b/279212943
How has this been tested?
Checklist: