Skip to content

Add tracking tag to MetricsMode in OTLP receiver #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2023
Merged

Add tracking tag to MetricsMode in OTLP receiver #1358

merged 4 commits into from
Aug 2, 2023

Conversation

@avilevy18
Copy link
Contributor

@avilevy18 avilevy18 commented Aug 1, 2023 •
edited
Loading

Description

Update MetricsMode in OTLP receiver param to include feature tracking tag.

Related issue

b/294071415

How has this been tested?

Integration tests

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@avilevy18 avilevy18 marked this pull request as ready for review August 1, 2023 17:20
@avilevy18 avilevy18 requested review from a team and ridwanmsharif and removed request for a team August 1, 2023 17:20
@ridwanmsharif
Copy link
Contributor

ridwanmsharif commented Aug 1, 2023

LGTM modulo the test failures. I think you have to add this to the integration tests too.

@avilevy18 avilevy18 added the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 2, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Aug 2, 2023
@avilevy18 avilevy18 merged commit b4438c2 into master Aug 2, 2023
@avilevy18 avilevy18 deleted the avilevy-otlp-metrics-mode-ft branch August 2, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avilevy18 @ridwanmsharif @stackdriver-instrumentation-release