Skip to content

Testing: disable OS Config patch management for soak tests #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2023
Merged

Testing: disable OS Config patch management for soak tests #1367

merged 3 commits into from
Aug 9, 2023

Conversation

@martijnvans
Copy link
Contributor

@martijnvans martijnvans commented Aug 9, 2023 •
edited by igorpeshansky
Loading

Description

This is to avoid mid-test reboots. The idea is to disable patch management features in OS Config: https://cloud.google.com/compute/docs/manage-os#disable-features

Related issue

b/295165549

How has this been tested?

automated tests only

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans
Testing: disable OS Config agent for soak tests
3329e40 
Just a strawman at this point. We are looking for better ways to do this.
igorpeshansky
igorpeshansky reviewed Aug 9, 2023
View reviewed changes
@martijnvans martijnvans changed the title Testing: disable OS Config agent for soak tests Testing: disable OS Config patch management for soak tests Aug 9, 2023
@martijnvans martijnvans marked this pull request as ready for review August 9, 2023 15:16
igorpeshansky
igorpeshansky approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@martijnvans martijnvans merged commit d069871 into master Aug 9, 2023
@martijnvans martijnvans deleted the martijnvans-disable-os-config-agent branch August 9, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijnvans @igorpeshansky