Skip to content

Conversation

@quentinmit
Copy link
Member

Since there is currently nothing users can usefully do with exporters, removing the fields from the default configs will reduce user confusion.

The fields are still parsed (but ignored), which means we're backwards compatible, and we can always reintroduce them in the future if needed.

Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quentinmit quentinmit merged commit 872ab31 into master Jul 2, 2021
@quentinmit quentinmit deleted the quentin-no-exporters branch July 2, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants