Skip to content

confgenerator: redact passwords from 3P integrations #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

confgenerator: redact passwords from 3P integrations #1320

merged 1 commit into from
Jul 7, 2023

Conversation

@ridwanmsharif
Copy link
Contributor

@ridwanmsharif ridwanmsharif commented Jul 6, 2023

Description

This change replaces all the Passwords to use the secret.String type so when the config is logged, it doesn't leak sensitive data.

Related issue

b/290250205 | OracleDB Metrics integration logs password in plain text

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@ridwanmsharif
confgenerator: redact passwords from 3P integrations
55a87c6 
This change replaces all the Passwords to use the `secret.String` type
so when the config is logged, it doesn't leak sensitive data.
@ridwanmsharif ridwanmsharif requested review from a team and rafaelwestphal and removed request for a team July 6, 2023 23:08
@ridwanmsharif ridwanmsharif added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 7, 2023
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 7, 2023
@ridwanmsharif ridwanmsharif merged commit 1269f76 into master Jul 7, 2023
igorpeshansky
igorpeshansky reviewed Jul 7, 2023
View reviewed changes
@igorpeshansky igorpeshansky deleted the ridwanmsharif-redact branch July 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelwestphal rafaelwestphal rafaelwestphal approved these changes

+1 more reviewer

@igorpeshansky igorpeshansky igorpeshansky left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ridwanmsharif @rafaelwestphal @igorpeshansky @stackdriver-instrumentation-release