Skip to content

Testing: Fix DCGM install script #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2023
Merged

Testing: Fix DCGM install script #1494

merged 2 commits into from
Nov 7, 2023

Conversation

@LujieDuan
Copy link
Contributor

@LujieDuan LujieDuan commented Nov 3, 2023 •
edited
Loading

Description

On Debian 11 with the new DCGM 3.3, the dcgmi discovery -l will fail to get CPU info which we don't need. Ignore the return code of the command in the installation script.

Related issue

b/309148533

How has this been tested?

Integration test for DCGM passed on Debian 11.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@LujieDuan LujieDuan marked this pull request as ready for review November 6, 2023 15:07
@LujieDuan LujieDuan requested review from a team and igorpeshansky and removed request for a team November 6, 2023 15:09
@LujieDuan LujieDuan force-pushed the lujieduan-fix-dcgm-discovery-issue branch from aa1af0e to ac4fdfa Compare November 6, 2023 21:10
igorpeshansky
igorpeshansky reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional suggestion; otherwise LGTM. Will approve once we decide what to do with the suggested change.

@LujieDuan @igorpeshansky
Update integration_test/third_party_apps_data/applications/dcgm/debia…
316a061 
…n_ubuntu/install

Co-authored-by: igorpeshansky <igorpeshansky@users.noreply.github.com>
igorpeshansky
igorpeshansky approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@LujieDuan LujieDuan merged commit 1198e49 into master Nov 7, 2023
@LujieDuan LujieDuan deleted the lujieduan-fix-dcgm-discovery-issue branch November 7, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LujieDuan @igorpeshansky