Skip to content

Fix Windows 3p test flakes #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix Windows 3p test flakes #1408

merged 1 commit into from
Sep 7, 2023

Conversation

@jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Sep 6, 2023 •
edited
Loading

Description

I can produce the same error as the nightlies by calling Stop-Service too quickly after starting the Ops Agent -- apparently Stop-Service fails if the service isn't 'Running' yet. So just wait for them to be fully running before stopping.

Related issue

b/295867239

How has this been tested?

Will let the presubmits + nightlies run

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@jefferbrecht jefferbrecht force-pushed the jefferbrecht-windows-flake branch from b9c2af9 to a7a4aee Compare September 7, 2023 04:49
@jefferbrecht jefferbrecht changed the title Trying some printf debugging for the Windows flake Fix Windows 3p test flakes Sep 7, 2023
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-windows-flake branch from a7a4aee to 8a04cd2 Compare September 7, 2023 04:52
@jefferbrecht jefferbrecht marked this pull request as ready for review September 7, 2023 04:53
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-windows-flake branch from 8a04cd2 to 49455b8 Compare September 7, 2023 04:54
@jefferbrecht
Wait for fully running services before stopping
094bed4 
This should prevent the Stop-Service failure flake we've been seeing.
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-windows-flake branch from 49455b8 to 094bed4 Compare September 7, 2023 17:44
@jefferbrecht
Copy link
Member Author

jefferbrecht commented Sep 7, 2023

Failing tests are either expected, unrelated to this change, or passed on an earlier run; merging.

@jefferbrecht jefferbrecht merged commit c5bffb3 into master Sep 7, 2023
@jefferbrecht jefferbrecht deleted the jefferbrecht-windows-flake branch September 7, 2023 20:48
@jefferbrecht jefferbrecht mentioned this pull request Jan 19, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvans martijnvans martijnvans approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferbrecht @martijnvans