Skip to content

simulacra: Fix logger usage in Simulacra. #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

simulacra: Fix logger usage in Simulacra. #1528

merged 1 commit into from
Nov 28, 2023

Conversation

@franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Nov 28, 2023

Description

After #1501 there is a need to update how logger is used in simulacra.

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro changed the title Fix logger usage in Simulacra. simulacra: Fix logger usage in Simulacra. Nov 28, 2023
@franciscovalentecastro franciscovalentecastro requested review from a team and avilevy18 and removed request for a team November 28, 2023 15:29
@franciscovalentecastro franciscovalentecastro merged commit 0e83db0 into master Nov 28, 2023
@igorpeshansky igorpeshansky deleted the fcovalente-fix-simulacra branch July 23, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braydonk braydonk braydonk approved these changes

@avilevy18 avilevy18 avilevy18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franciscovalentecastro @braydonk @avilevy18