Add whitespace ignore to distro detector script #1847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last night the distro detector failed on an empty line in the diff. I'm not sure how that happened, and running the script over and over can't reproduce it. Regardless, we don't ever want to fail on something like that since it alerts on-call unnecessarily. This PR adds flags to the diff command to ignore blank lines and whitespace.
Related issue
b/384688415
How has this been tested?
I ran it the first time to test it, and reproduced the problem backwards (the one produced by the command didn't have the newline anymore). Of course this corrected it, because the no-empty-line version was then uploaded to the bucket. So I commented out the beginning of the script and manually edited the local copy of
current_families.txtI had and added the opening newline, and testing it with and without the new flags to ensure that this scenario would be caught in the future.Checklist: