Skip to content

Conversation

@braydonk
Copy link
Contributor

Description

Last night the distro detector failed on an empty line in the diff. I'm not sure how that happened, and running the script over and over can't reproduce it. Regardless, we don't ever want to fail on something like that since it alerts on-call unnecessarily. This PR adds flags to the diff command to ignore blank lines and whitespace.

Related issue

b/384688415

How has this been tested?

I ran it the first time to test it, and reproduced the problem backwards (the one produced by the command didn't have the newline anymore). Of course this corrected it, because the no-empty-line version was then uploaded to the bucket. So I commented out the beginning of the script and manually edited the local copy of current_families.txt I had and added the opening newline, and testing it with and without the new flags to ensure that this scenario would be caught in the future.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@braydonk
Copy link
Contributor Author

This has nothing to do with our integration tests, merging without waiting for them.

@braydonk braydonk merged commit a6f4b6e into master Dec 17, 2024
36 of 65 checks passed
@braydonk braydonk deleted the braydonk-distro-detector-space branch December 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants