Skip to content

Add logging labels with GCE instance's managed instance group. #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2025
Merged

Add logging labels with GCE instance's managed instance group. #1849

merged 5 commits into from
Feb 20, 2025

Conversation

@quentinmit
Copy link
Member

@quentinmit quentinmit commented Dec 27, 2024 •
edited by franciscovalentecastro
Loading

Description

OTel now has resource detection for MIGs, but we need to make that available in Cloud Logging since resource attributes don't appear normally in Cloud Logging.

This PR depends on some newly added features to the resourcedetection processor which which were added to the Ops Agent in #1892. Marked as draft until we can also pull in the new otelopscol with the corresponding metrics + trace changes.

Manual testing shows the labels being added correctly :

MIG_screenshot

MIG_screeshot_region

Related issue

b/354756009

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro marked this pull request as ready for review February 20, 2025 16:47
@franciscovalentecastro franciscovalentecastro requested review from a team and avilevy18 and removed request for a team February 20, 2025 16:47
avilevy18
avilevy18 reviewed Feb 20, 2025
View reviewed changes
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 20, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Feb 20, 2025
@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Feb 20, 2025

Rerun integration tests to cross-reference if some failures were flakes or not. All integration test failures resulted unrelated. Merging.

@franciscovalentecastro franciscovalentecastro merged commit b0665b3 into master Feb 20, 2025
81 of 87 checks passed
@franciscovalentecastro franciscovalentecastro deleted the quentin-mig branch February 20, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro left review comments

@avilevy18 avilevy18 avilevy18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@quentinmit @franciscovalentecastro @avilevy18 @stackdriver-instrumentation-release