Skip to content

MySQL test changes on SLES #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

MySQL test changes on SLES #1866

merged 2 commits into from
Jan 24, 2025

Conversation

@jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Jan 24, 2025 •
edited
Loading

Description

MySQL is no longer supported on SLES 12, which went EOL in Oct 2024 -- removing it from the tests.

SLES 15 has updated installation instructions which is also fixed in this PR.

Related issue

http://b/392091183

How has this been tested?

Presubmits

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

LujieDuan
LujieDuan approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@LujieDuan LujieDuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jefferbrecht jefferbrecht force-pushed the jefferbrecht-sles12-mysql branch from f762cbe to a7ae642 Compare January 24, 2025 18:04
@jefferbrecht jefferbrecht changed the title Remove MySQL from SLES 12 tests MySQL test changes on SLES Jan 24, 2025
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-sles12-mysql branch from a7ae642 to 74cf581 Compare January 24, 2025 18:59
LujieDuan
LujieDuan approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@LujieDuan LujieDuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jefferbrecht
Remove MySQL from SLES 12 tests
1df8b73 
MySQL is no longer supported on SLES 12, which went EOL in Oct 2024.
@jefferbrecht
Fix SLES 15
b55ed89 
The instructions to install MySQL on SLES have changed slightly.
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-sles12-mysql branch from 74cf581 to b55ed89 Compare January 24, 2025 21:55
@jefferbrecht
Copy link
Member Author

jefferbrecht commented Jan 24, 2025

Test failures look unrelated, will merge after the unit tests pass post-rebase.

@jefferbrecht jefferbrecht merged commit 4a49c1d into master Jan 24, 2025
37 of 61 checks passed
@jefferbrecht jefferbrecht deleted the jefferbrecht-sles12-mysql branch January 24, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LujieDuan LujieDuan LujieDuan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferbrecht @LujieDuan