Skip to content

fix: remove artemis support from list of supported platforms of activemq #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 17, 2025
Merged

fix: remove artemis support from list of supported platforms of activemq #1867

merged 8 commits into from
Jun 17, 2025

Conversation

@schmikei
Copy link
Collaborator

@schmikei schmikei commented Jan 28, 2025

Description

The MBean targets are different between base ActiveMQ and Artemis ActiveMQ

ActiveMQ MBeans
image

Artemis Process MBeans
image

The target system of activemq is not going to be looking for artemis metrics

Related issue

Resolves #1857

Potentially #1856

How has this been tested?

This is a documentation change as the listed support should not have been added in the first place.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@schmikei schmikei marked this pull request as ready for review January 28, 2025 16:53
@schmikei schmikei mentioned this pull request Jan 28, 2025
Closed
@schmikei schmikei added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 28, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jan 28, 2025
@github-actions
Copy link

github-actions bot commented May 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 8, 2025
@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Jun 17, 2025 •
edited
Loading

@schmikei Followup : Is this PR still ready for merging ?

@franciscovalentecastro franciscovalentecastro merged commit 103653a into GoogleCloudPlatform:master Jun 17, 2025
60 of 68 checks passed
@schmikei
Copy link
Collaborator Author

schmikei commented Jun 18, 2025

@schmikei Followup : Is this PR still ready for merging ?

@franciscovalentecastro yep this was good to merge as the mbeans for artemis are different and were not being collected! Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaelwestphal rafaelwestphal rafaelwestphal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ActiveMQ integration doesn't work with ActiveMQ Artemis

5 participants

@schmikei @franciscovalentecastro @rafaelwestphal @igorpeshansky @stackdriver-instrumentation-release