Skip to content

Conversation

@franciscovalentecastro
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro commented Feb 26, 2025

Description

The UnifiedConfig.OTelLoggingSupported method requires the Merged Unified Config (the result of combining the user set config and the built in config ) to determine correctly if "OTel Logging" supports the presented logging pipelines.

This breaks the Feature Tracking design of only analyzing the user configuration, but the alternatives (e.g. refactor Unified Config) would need refactoring in other packages or present other issues (e.g. apps and confgenerator dependency cycle). The mergedUc is only used for getOTelLoggingSupportedConfig.

The use for otel_logging_supported_config will be removed when Otel Logging Support is fully released (see b/399354366). Added TODO to track this.

This is a followup the PR's :

Explanation

The merged config is required to be able to match exactly the OTel Logging Support feedback a user would get when trying to enable experimental_otel_logging: true from the congenerator config validation. The config validation uses the merged config with the built in config pipelines. When using only the user config, there are edge cases (see goldens example ) where a logging processors might not detected as not supported (e.g. parse_regex in the example).

Related issue

  • b/390671495
  • b/399354366

How has this been tested?

Unit tests were modified.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • [] Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro franciscovalentecastro changed the title feature_tracking : Update ExtractFeatures to receiver both userUc and mergedUc for getOTelLoggingSupportedConfig. feature_tracking : Update ExtractFeatures to receive both userUc and mergedUc for getOTelLoggingSupportedConfig. Feb 26, 2025
@franciscovalentecastro franciscovalentecastro requested review from a team, avilevy18, braydonk and quentinmit and removed request for a team February 26, 2025 14:33
@franciscovalentecastro franciscovalentecastro merged commit 7f47d81 into master Feb 26, 2025
70 of 72 checks passed
@franciscovalentecastro franciscovalentecastro deleted the fcovalente-otel-logging-supported-fix branch February 26, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants