Skip to content

Address pipe-read race condition #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

Address pipe-read race condition #1834

merged 1 commit into from
Nov 27, 2024

Conversation

@jefferbrecht
Copy link
Member

@jefferbrecht jefferbrecht commented Nov 21, 2024 •
edited by igorpeshansky
Loading

Description

cmd.Wait() must not be called before reading completes; it was previously being called too early.

Related issue

b/372525646

How has this been tested?

Tests passed locally

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@jefferbrecht jefferbrecht force-pushed the jefferbrecht-transformtests branch from 801db3a to 6a0d81b Compare November 21, 2024 21:37
@jefferbrecht jefferbrecht changed the title Handle process termination race Address pipe-read race condition Nov 21, 2024
@jefferbrecht
Address pipe-read race condition
0536c9a 
cmd.Wait() must not be called before reading completes; it was previously being called too early.
@jefferbrecht jefferbrecht force-pushed the jefferbrecht-transformtests branch from 6a0d81b to 0536c9a Compare November 26, 2024 20:14
@jefferbrecht jefferbrecht merged commit 1a21b8f into master Nov 27, 2024
66 of 69 checks passed
@jefferbrecht jefferbrecht deleted the jefferbrecht-transformtests branch November 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quentinmit quentinmit quentinmit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferbrecht @quentinmit