Skip to content

feat: Update varnish receiver to use LoggingProcessorMacro #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2025
Merged

feat: Update varnish receiver to use LoggingProcessorMacro #1989

merged 7 commits into from
Jul 25, 2025

Conversation

@Caleb-Hurshman
Copy link
Collaborator

@Caleb-Hurshman Caleb-Hurshman commented Jul 21, 2025 •
edited
Loading

Description

Refactor the varnish receiver logging to be sub-agent agnostic.

Related issue

How has this been tested?

Updated transformation_test and confgenerator_test, confirmed the output of output_fluentbit.yaml was unchanged after refactoring the receiver.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 21, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 21, 2025
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@Caleb-Hurshman Caleb-Hurshman changed the title feat: Update varnish receiver to use LoggingReceiverMacro feat: Update varnish receiver to use LoggingProcessorMacro Jul 22, 2025
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/varnish-otel-logging branch from f4fd893 to 8b2cdde Compare July 22, 2025 18:10
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
franciscovalentecastro
franciscovalentecastro approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 23, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 23, 2025
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/varnish-otel-logging branch from 8b2cdde to d0185ee Compare July 23, 2025 20:38
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/varnish-otel-logging branch from d0185ee to cee00e0 Compare July 24, 2025 17:31
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 24, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 24, 2025
@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Jul 24, 2025

Note : This PR may need to run make test_confgenerator_update again after resolving the merge conflicts in golden.csv.

@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 24, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 24, 2025
@franciscovalentecastro franciscovalentecastro merged commit f3b559b into GoogleCloudPlatform:master Jul 25, 2025
51 of 62 checks passed
@Caleb-Hurshman Caleb-Hurshman deleted the feat/varnish-otel-logging branch July 25, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

review-focus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Caleb-Hurshman @franciscovalentecastro @stackdriver-instrumentation-release