Skip to content

Transform Hex strings to integers #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

Transform Hex strings to integers #1990

merged 2 commits into from
Jul 24, 2025

Conversation

@XuechunHou
Copy link
Contributor

@XuechunHou XuechunHou commented Jul 22, 2025 •
edited
Loading

Description

Used ottl.ParseInt(hexString, 16) to convert certain hex strings to int64. Hex strings without 0x prefix, e.g: "AFFFF", "+123C" , "-1b1b" are converted to int64 with ottl.ParseInt(hexString, 16)

Related issue

b/424478327

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

quentinmit
quentinmit approved these changes Jul 23, 2025
View reviewed changes
confgenerator/logging_processors.go Outdated
Copy link
Member

@quentinmit quentinmit Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's equivalent to a uint64 in Go.

Copy link
Contributor Author

@XuechunHou XuechunHou Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@XuechunHou XuechunHou merged commit 173f455 into master Jul 24, 2025
46 of 68 checks passed
@XuechunHou XuechunHou deleted the hex-string branch July 24, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quentinmit quentinmit quentinmit approved these changes

@franciscovalentecastro franciscovalentecastro Awaiting requested review from franciscovalentecastro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XuechunHou @quentinmit