Skip to content

feat: Update Apache receiver to use LoggingReceiverMacro #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 30, 2025
Merged

feat: Update Apache receiver to use LoggingReceiverMacro #1992

merged 6 commits into from
Jul 30, 2025

Conversation

@Caleb-Hurshman
Copy link
Collaborator

@Caleb-Hurshman Caleb-Hurshman commented Jul 22, 2025 •
edited
Loading

Description

Refactor the apache receiver logging to be sub-agent agnostic.

Related issue

How has this been tested?

Updated transformation_test and confgenerator_test, confirmed the output of output_fluentbit.yaml was unchanged after refactoring the receiver.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/apache-otel-logging branch from 6904756 to 8c109d9 Compare July 22, 2025 18:11
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 22, 2025
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/apache-otel-logging branch from 8c109d9 to 36df4e9 Compare July 23, 2025 20:39
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 23, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 23, 2025
franciscovalentecastro
franciscovalentecastro reviewed Jul 24, 2025
View reviewed changes
apps/common_logging_processors.go Outdated
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing the idea of converting genericAccessLogParserAsInternalLoggingProcessor into an InternalLoggingProcessor!

Sorry, now i'm realizing that the idea of converting it to an InternalLoggingProcessor was faulty because :

  • The resulting processor GenericAccessLogParser dependent on fluentbit.Component , which makes it not agent agnostic (e.g this would require an otel implementation too).
  • It doesn't necessarily improve the readability.

My recommendation is to revert it back to only use genericAccessLogParserAsInternalLoggingProcessor during the migration.

...generator/testdata/goldens/invalid-logging-otel-unsupported_processor/golden/linux-gpu/error Outdated
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note : This changes are expected.

@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/apache-otel-logging branch from 36df4e9 to 3e1580c Compare July 25, 2025 12:49
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 25, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 25, 2025
franciscovalentecastro
franciscovalentecastro approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 29, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 29, 2025
@Caleb-Hurshman Caleb-Hurshman force-pushed the feat/apache-otel-logging branch from d3cf3ca to 1cbe87b Compare July 29, 2025 15:58
@Caleb-Hurshman Caleb-Hurshman added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 29, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 29, 2025
@franciscovalentecastro franciscovalentecastro added the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 29, 2025
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Jul 29, 2025
@franciscovalentecastro franciscovalentecastro merged commit 5232108 into GoogleCloudPlatform:master Jul 30, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

review-focus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Caleb-Hurshman @franciscovalentecastro @stackdriver-instrumentation-release