Skip to content

feat: Updated all MySql receivers to use LoggingReceiverMacro #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 19, 2025
Merged

feat: Updated all MySql receivers to use LoggingReceiverMacro #1994

merged 11 commits into from
Aug 19, 2025

Conversation

@dyl10s
Copy link
Collaborator

@dyl10s dyl10s commented Jul 22, 2025

Description

Refactored all 3, general, error, slow receiver logs to be sub-agent agnostic.

Related issue

How has this been tested?

Updated transformation_test and confgenerator_test, confirmed the output of output_fluentbit.yaml was unchanged after refactoring the receiver.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

franciscovalentecastro
franciscovalentecastro approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Jul 28, 2025

Note: This PR may need to run make test_confgenerator_update again after solving merge conflicts & rebasing due to mismatches in golden.csv.

@dyl10s dyl10s force-pushed the feat/mysql-refactor branch 2 times, most recently from 3547e30 to f1f7d5c Compare July 30, 2025 21:09
franciscovalentecastro
franciscovalentecastro requested changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment.

@dyl10s dyl10s force-pushed the feat/mysql-refactor branch from 46933c3 to 4addcb9 Compare July 31, 2025 15:26
franciscovalentecastro
franciscovalentecastro approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

franciscovalentecastro
franciscovalentecastro requested changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two nit comments.

franciscovalentecastro
franciscovalentecastro approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro franciscovalentecastro merged commit c00a837 into GoogleCloudPlatform:master Aug 19, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

review-focus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyl10s @franciscovalentecastro