Skip to content

feat: Update Tomcat receiver to use LoggingReceiverMacro #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 29, 2025
Merged

feat: Update Tomcat receiver to use LoggingReceiverMacro #1995

merged 4 commits into from
Jul 29, 2025

Conversation

@dyl10s
Copy link
Collaborator

@dyl10s dyl10s commented Jul 22, 2025

Description

Refactored the Tomcat access and system logging receivers to use LoggingReceiverMacro

Related issue

How has this been tested?

Updated transformation_test and confgenerator_test, confirmed the output of output_fluentbit.yaml was unchanged after refactoring both of the receivers.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

franciscovalentecastro
franciscovalentecastro approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note : Same as mentioned in other PRs, this may need to run again make test_confgenerator_update after rebasing due merge conflicts in golden.csv.

@franciscovalentecastro franciscovalentecastro merged commit 3884d62 into GoogleCloudPlatform:master Jul 29, 2025
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

review-focus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyl10s @franciscovalentecastro