Skip to content

feat: Update Cassandra receiver to use LoggingReceiverMacro #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 18, 2025
Merged

feat: Update Cassandra receiver to use LoggingReceiverMacro #1999

merged 11 commits into from
Aug 18, 2025

Conversation

@dyl10s
Copy link
Collaborator

@dyl10s dyl10s commented Jul 23, 2025

Description

Refactored the Cassandra system, debug and gc logging receivers to use LoggingReceiverMacro

Related issue

How has this been tested?

Updated transformation_test and confgenerator_test, confirmed the output of output_fluentbit.yaml was unchanged after the refactor was completed for all 3 receivers.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@franciscovalentecastro
Copy link
Contributor

franciscovalentecastro commented Jul 29, 2025

This PR looks good to me, but there are transformation test failures due errors when parsing multi-line YAML fields. The change in #2010 seems to fix this. We can move forward after the fix is merged.

@franciscovalentecastro franciscovalentecastro mentioned this pull request Jul 29, 2025
Merged
9 tasks
@dyl10s dyl10s force-pushed the feat/cassandra-refactor branch from bd3e7c7 to 7298e03 Compare July 31, 2025 13:25
franciscovalentecastro
franciscovalentecastro approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@franciscovalentecastro franciscovalentecastro merged commit 2d108d4 into GoogleCloudPlatform:master Aug 18, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

Assignees

No one assigned

Labels

review-focus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyl10s @franciscovalentecastro