Skip to content

Revert json pretty format to json files. #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

Revert json pretty format to json files. #1921

merged 3 commits into from
Mar 31, 2025

Conversation

@rafaelwestphal
Copy link
Contributor

@rafaelwestphal rafaelwestphal commented Mar 31, 2025 •
edited by franciscovalentecastro
Loading

Description

Reverting changes to #1911 json format.
This format is invalid when using otlpjsonfile receiver as it expects a valid json entry per line.

  • fix a bug where the we were missing a new line at the end of the json.
  • fix a bug where the we were missing resources on the json.

Related issue

b/396458573

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

franciscovalentecastro
franciscovalentecastro approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ridwanmsharif
ridwanmsharif approved these changes Mar 31, 2025
View reviewed changes
@rafaelwestphal rafaelwestphal merged commit 1fd2474 into master Mar 31, 2025
13 of 22 checks passed
@rafaelwestphal rafaelwestphal deleted the westphalrafael-revert-json branch March 31, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscovalentecastro franciscovalentecastro franciscovalentecastro approved these changes

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafaelwestphal @franciscovalentecastro @ridwanmsharif