Skip to content

Conversation

@XuechunHou
Copy link
Contributor

@XuechunHou XuechunHou commented Aug 6, 2025

Description

Transform jsonPayload.event_data.data which is a slice of maps, to a slice of the values of the map.

The custom ottl function: https://github.com/GoogleCloudPlatform/opentelemetry-operations-collector/blob/master/internal/ottlfuncs/func_to_values.go is used to perform this transformation.

Related issue

https://b.corp.google.com/issues/424476367

How has this been tested?

Transformation test

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@XuechunHou XuechunHou requested review from franciscovalentecastro and quentinmit and removed request for quentinmit August 6, 2025 17:52
@XuechunHou XuechunHou self-assigned this Aug 6, 2025
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo verifying why the [Test / test (ubuntu-latest) (push)] failed. Seems related to the make test_metadata test failing.

@XuechunHou
Copy link
Contributor Author

LGTM modulo verifying why the [Test / test (ubuntu-latest) (push)] failed. Seems related to the make test_metadata test failing.

Reran it and passed.

@XuechunHou XuechunHou merged commit fb491d8 into master Aug 6, 2025
54 of 64 checks passed
@XuechunHou XuechunHou deleted the slice-of-maps branch August 6, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants