Skip to content

Adding new confgenerator testcase #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

Adding new confgenerator testcase #2028

merged 1 commit into from
Aug 11, 2025

Conversation

@rafaelwestphal
Copy link
Contributor

@rafaelwestphal rafaelwestphal commented Aug 11, 2025 •
edited
Loading

Description

This new test case will be used to verify the new otlp exporter feature when exporting Prometheus metrics.

Related issue

b/435218442

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

ridwanmsharif
ridwanmsharif reviewed Aug 11, 2025
View reviewed changes
confgenerator/testdata/goldens/metrics-exporter_prometheus_otlp/golden/linux/otel.yaml
@@ -0,0 +1,608 @@
exporters:
googlecloud:
metric:
Copy link
Contributor

@ridwanmsharif ridwanmsharif Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like the exporter was added though?

Copy link
Contributor Author

@rafaelwestphal rafaelwestphal Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exporter will be added on a follow up PR. The idea is to make it easier to review since the changes will show on the diff.

ridwanmsharif
ridwanmsharif approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@ridwanmsharif ridwanmsharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding the base for the upcoming changes to make review simpler.

@rafaelwestphal rafaelwestphal merged commit cb22b94 into master Aug 11, 2025
54 of 57 checks passed
@rafaelwestphal rafaelwestphal deleted the westphalrafael-new-confgenerator-test branch August 11, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ridwanmsharif ridwanmsharif ridwanmsharif approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rafaelwestphal @ridwanmsharif